A hash ( # ) should not be stripped from approval name

[markijbema]

I noticed I test a lot of controller actions, so my names tend to be something like

"blogposts#show.json should stay the same"

I think we can do better handling of the # than stripping it. (this would mean a breaking change though, but I think this is still okay, as long as we add it to the changelog)

[kytrinyx]

We still haven't hit 1.0, so breaking changes are considered acceptable.

How do you want to handle it. Replace it with a hyphen, perhaps?

[markijbema]

Yeah, hyphen or underscore seems fine (i recall that everything is changed to underscore, but I don't have the conversion at hand).

Btw, I'm perfectly willing to implement this somewhere in the coming weeks, but I noticed it, so just jotted it down here, so I don't forget again (because I noticed it before ;) )

[kytrinyx]

Ok, cool -- and agreed, this is a good change.