Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hanami support #125

Closed
4 tasks
matsimitsu opened this issue Aug 23, 2016 · 7 comments · Fixed by #906
Closed
4 tasks

Add Hanami support #125

matsimitsu opened this issue Aug 23, 2016 · 7 comments · Fixed by #906
Assignees
Labels

Comments

@matsimitsu
Copy link
Member

matsimitsu commented Aug 23, 2016

We've had a few customers ask about supporting Hanami (http://hanamirb.org/)

Support Hanami 2.0. It's now available as release candidate 1.


⚠️ Old issue content from 2016-2017:

Hanami Controller

Hanami is split out in a few different projects, one of them is Hanami-Controller, it has a section about error handling: https://github.com/hanami/controller#exceptions-management

It looks like it does error handling on its own:
https://github.com/hanami/controller/blob/master/lib/hanami/controller/configuration.rb#L113


@tombruijn: Since we received PR #322 we need to look at what steps we need to take to merge this in

TODO

  • Review if the approach in PR Hanami support #322 with middleware is the best approach (0.5 days)
  • Rewrite tests (0.5-0.75 days)
    • Use transaction.to_hsee PR Hanami support #322 for detailed description of rewrite needed
    • Convert from unit testing to more integration testing than just unit testing (by which I mean, do not just unit test the middleware, but unit test it through/with a real Hanami app. Something which I improved in our Grape integration specs recently.)
  • Add Hanami integration documentation (0.25-0.5 days)
  • Set up an example app on https://github.com/appsignal/appsignal-examples (0.5-0.75 days)
    • Test basic single app integration
    • Test multi app integration
    • Test other edge cases described in documentation
@matsimitsu matsimitsu self-assigned this Aug 23, 2016
@thijsc thijsc added this to the 2.2 milestone Feb 27, 2017
@tombruijn tombruijn modified the milestones: 2.3, 2.2 May 3, 2017
@tombruijn tombruijn modified the milestones: 2.4, 2.3 Jun 13, 2017
@tombruijn
Copy link
Member

tombruijn commented Jul 24, 2017

Updated the issue description with a TODO list of steps we need to take to support Hanami fully.

@tombruijn tombruijn changed the title Add Hanami support 🚀 Add Hanami support Oct 20, 2017
@tombruijn tombruijn changed the title 🚀 Add Hanami support Add Hanami support May 30, 2018
@gotar
Copy link

gotar commented Nov 25, 2019

New hanami will use ROM (Ruby Object Mapper) Will be good to have out of box support for it too (rom-sql use Sequel below, so maybe this will be helpful)

@tombruijn tombruijn removed this from the Ruby gem 3.0 milestone Nov 14, 2022
@backlog-helper
Copy link

This issue seems is labelled as a new feature. Our customers may want to be informed about these changes through a blog post announcement. An issue has been created in blog repo so we remember to publish a blog post about it.

If a blog post is not required, please add the [skip blogpost] tag next time, and close the created issue.

@luismiramirez luismiramirez linked a pull request Dec 16, 2022 that will close this issue
1 task
@luismiramirez luismiramirez linked a pull request Dec 29, 2022 that will close this issue
@luismiramirez
Copy link
Member

Hanami v2 is now supported in AppSignal for Ruby gem 3.3.0 (https://rubygems.org/gems/appsignal/versions/3.3.0)

Follow instructions here: https://docs.appsignal.com/ruby/integrations/hanami.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants