Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not restart the agent if POST /update call should do nothing #957

Open
Xayton opened this issue May 23, 2024 · 0 comments
Open

Do not restart the agent if POST /update call should do nothing #957

Xayton opened this issue May 23, 2024 · 0 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Milestone

Comments

@Xayton
Copy link
Contributor

Xayton commented May 23, 2024

When the agent processes the POST /update command, it will check if the latest version is newer than the agent version. If it's not, the command should not do anything. Instead it always restarts the agent.

  • It should also download the full executable only when it's not on the latest version, instead of always doing it.
  • If possible, the user agent used when downloading the updates should be changed from the default Go-http-client/2.0 to something like Arduino-Cloud-Agent/1.5.0.

https://github.com/arduino/arduino-create-agent/blob/main/update.go#L37-L49
The code above should be improved.

@Xayton Xayton added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels May 23, 2024
@Xayton Xayton added this to the next milestone Jul 15, 2024
@Xayton Xayton modified the milestones: 1.7.0, next Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

1 participant