Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHL version #11

Open
stijnb1234 opened this issue Jan 2, 2024 · 7 comments
Open

DHL version #11

stijnb1234 opened this issue Jan 2, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@stijnb1234
Copy link

Love the concept of this integration, it works great for the PostNL packages! Could you look into a version for DHL too? DHL has https://my.dhlparcel.nl/ which also auto-detects all the packages sent to you.

@arjenbos
Copy link
Owner

arjenbos commented Jan 6, 2024

Hi @stijnb1234 ,

Thanks!

In my dev environment I already have a working proof of concept for DHL, but I need to decide on my next steps. Some issues:

  • Not sure if DHL should be added to this integration. I think it will go against the concept of Home Assistant. Every "brand" aka domain should have his own integration., for me it feels like I'm not following the concept of HA if I add DHL to the PostNL integration. So either, I rename this integration or create a separate integration for DHL.
  • The lovelace doesn't support multiple entities. I already forked the lovelace, because I want to include the lovelace in the integration. By doing this, we do not relay on an archived repository.
  • Currently, all data is stored in the attributes of an entity, this is required by the lovelace. This is not ideal (other official integrations do this as well so it's not that bad). I want to switch to the Calendar entity and add events. By doing this, people can create automatons based on the shipments. I have a work in progress pull request open for this: Add calendar sensor #12.

So, TLDR: I first want to change some architectural stuff before I add DHL.

@arjenbos arjenbos added the enhancement New feature or request label Jan 6, 2024
@stijnb1234
Copy link
Author

I understand. Nice to hear you are working on it!

@stijnb1234
Copy link
Author

Hi @stijnb1234 ,

Thanks!

In my dev environment I already have a working proof of concept for DHL, but I need to decide on my next steps. Some issues:

  • Not sure if DHL should be added to this integration. I think it will go against the concept of Home Assistant. Every "brand" aka domain should have his own integration., for me it feels like I'm not following the concept of HA if I add DHL to the PostNL integration. So either, I rename this integration or create a separate integration for DHL.
  • The lovelace doesn't support multiple entities. I already forked the lovelace, because I want to include the lovelace in the integration. By doing this, we do not relay on an archived repository.
  • Currently, all data is stored in the attributes of an entity, this is required by the lovelace. This is not ideal (other official integrations do this as well so it's not that bad). I want to switch to the Calendar entity and add events. By doing this, people can create automatons based on the shipments. I have a work in progress pull request open for this: Add calendar sensor #12.

So, TLDR: I first want to change some architectural stuff before I add DHL.

My opinion on this: If you are planning to support more shipping providers, I recommend renaming it. If you only want to support PostNL and DHL, splitting it up is the way to go.

@Voxxie
Copy link

Voxxie commented Jan 8, 2024

I would say split the integration, combine the lovelace cards.

@stijnb1234
Copy link
Author

@arjenbos If you need help testing, please let me know.

@IIIdefconIII
Copy link

Woul be awesome!,
is it possible to do something likse this

  status: ne: delivered
  delivered: false
  first_letter: false
  header: false

@Voxxie
Copy link

Voxxie commented May 22, 2024

Hi @arjenbos ,
Any update on this ?
I am willing to help if needed.

Can you maybe share the DHL-code that you already created?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants