Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could you make a flatpak for playmyvideos? #15

Open
ghost opened this issue Jan 27, 2018 · 12 comments
Open

could you make a flatpak for playmyvideos? #15

ghost opened this issue Jan 27, 2018 · 12 comments

Comments

@ghost
Copy link

ghost commented Jan 27, 2018

Hi, I really appreciate your work , is a good application
but i don't use elementary OS
could you make a flatpak for playmyvideos?
in this way, users can install the application in any linux distribution

please.
thank you.

@worldofpeace
Copy link
Contributor

Hi @altntowin
There's been work done for this in playmymusic by @bil-elmoussaoui.
He also said:

Once this one is done, I will package the playmyvideos too :)

So expect this hopefully soon...

@bilelmoussaoui
Copy link

Yeah I can work on that 👍 I'm still waiting for some fixes on playmymusic so I can update the flatpak package

@artemanufrij
Copy link
Owner

@bil-elmoussaoui look here: flathub/flathub#229 (comment)

I need some information for fix appdata errors. Could you post me a link?

@bilelmoussaoui
Copy link

The Invalid style are not errors :) the missing tags are

@artemanufrij
Copy link
Owner

@bil-elmoussaoui thanks for feedback. I will fix it 👍

@artemanufrij
Copy link
Owner

@bil-elmoussaoui no more missing tags. fixed in here and in artemanufrij/playmymusic#55

@bilelmoussaoui
Copy link

There's still those missing cmake files :( there's two solutions, either to add them manually to the source code as I explained on the other issue or just switch to meson...

@artemanufrij
Copy link
Owner

@bil-elmoussaoui I will switch to meson after Juno release... have you a simple example for me how I can to create a cmake file?

@bilelmoussaoui
Copy link

Check out FeedReader source code. All you need is to copy the files I added as a patch to my PR in flathub and add that line I mentioned on the other issue which let cmake check that folder first for the required cmake modules

@artemanufrij
Copy link
Owner

@bilelmoussaoui I switched to meson. What are the next steps for creating a flatpak?

@bilelmoussaoui
Copy link

@artemanufrij can you ping me somewhere so I can build a Flatpak package for this? I might need some help with testing/dependencies :)

@artemanufrij
Copy link
Owner

artemanufrij commented Oct 31, 2018

@bilelmoussaoui ping :).
feel free to build a package 👍 if you need help, so let me know...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants