Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use the right docker image version in published artillery versions #2456

Conversation

bernardobridge
Copy link
Contributor

Description

Creates script to replace DEFAULT_IMAGE_TAG dynamically, and makes some changes to workflows to support it:

  • 1be8638: starts running docker publish as part of the npm publish. This is to prevent race condition where npm build might be pushed (with tests starting to use it) before publish is done.
  • 7d6e8c9, 7e18103: add replace script and use it in canary/artillery publishes
  • 219bff2: also publish worker image on canary publishes, since it is no longer doing so with push:main trigger
  • dbe2c01: only run canary when not releasing. this prevents images being published twice with the same tag, but also just makes sense, and prevents what currently happens where every release has a canary version published with it, which is unnecessary and confusing

Testing

Tested the substitution locally with a couple of strings and variations on the file. The canary that gets published to main on merging this should also test it!

Pre-merge checklist

This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.

  • Does this require an update to the docs? No
  • Does this require a changelog entry? Maybe, it does prevent the bug we had with last release.

@bernardobridge bernardobridge requested a review from a team January 31, 2024 18:47
@bernardobridge bernardobridge merged commit fd63c51 into main Feb 2, 2024
15 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1607-use-the-right-docker-image-version-in-published-versions-of branch February 2, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant