Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide Docker image tags for minor and major releases (coarser matching) #150

Closed
das-g opened this issue May 4, 2020 · 3 comments
Closed
Milestone

Comments

@das-g
Copy link

das-g commented May 4, 2020

Additionally to the tags with the full patch version x.y.z, provide tags that allow to be on the latest release of a certain minor version x.y and tags that allow to be on the latest release of a certain major version x.

So
Tag 1.1 should point to the same image as the latest 1.1.* tag (currently 1.1.0, later maybe 1.1.15, but never 1.2.0).
Tag 1 should point to the same image as the latest 1.*.* tag (currently 1.1.0, later maybe 1.5.42, but never 2.0.0).

Off course this is only really useful if this project uses semantic versioning. But although I didn't see it declared explicitly, I assume that's the case, isn't it?

@dduportal
Copy link
Contributor

Hello @das-g , thanks for opening this issue! The use case is described clearly, and it is a legit request.
We'll see how to implement this behavior, but if you feel ready, do not hesitate to open a PR with a proposal (even as a "draft"), as any help is welcome.

@das-g
Copy link
Author

das-g commented Jul 20, 2020

Hello @das-g , thanks for opening this issue! The use case is described clearly, and it is a legit request.
We'll see how to implement this behavior, [...]

Thanks!

I think this is best done through the autobuild configuration on dockerhub.

Type Name Dockerfile Location Docker Tag Name
Branch master / latest
Tag /^v([0-9]+)\.([0-9]+)\.([0-9]+)$/ / {\1}
Tag /^v([0-9]+)\.([0-9]+)\.([0-9]+)$/ / {\1}.{\2}
Tag /^v([0-9]+)\.([0-9]+)\.([0-9]+)$/ / {\1}.{\2}.{\3}

That would have to be done by someone with configuration access to https://github.com/asciidoctor/docker-asciidoctor.

[...] but if you feel ready, do not hesitate to open a PR with a proposal (even as a "draft"), as any help is welcome.

Whether there's any way to accomplish the same through a PR (i.e., by changing the content of files in this repo), I don't know.

@dduportal
Copy link
Contributor

Thanks a lot @das-g for these insights.

The release 1.2.0 had been published with this new tags, and the previous tagged version are currently being rebuilt: https://hub.docker.com/repository/docker/asciidoctor/docker-asciidoctor/tags?page=1

@dduportal dduportal added this to the 1.2.0 milestone Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants