Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Stop transforming custom auth params #249

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Dec 20, 2023

Purpose

This PR addresses the issue reported in asgardeo/asgardeo-auth-react-sdk#208, where the keys passed into the signIn hook are transformed into Snake Case, causing compatibility issues.

Goals

Approach

The issue was introduced with the changes in asgardeo/asgardeo-auth-js-core#203. The approach involves reverting the specific change that introduced the undesired key transformation.

Before

Screenshot 2023-12-20 at 18 21 33

After

Screenshot 2023-12-20 at 18 42 38

User stories

  • Users should be able to pass custom parameters to the signIn hook without having the keys transformed.

Release note

🔥 BREAKING CHANGE: Fixed an issue where custom parameters passed to the signIn hook were transformed into Snake Case, causing compatibility issues.

Documentation

N/A (No documentation impact)

Training

N/A (No training impact)

Certification

N/A (No impact on certification exams)

Marketing

N/A (No marketing impact)

Automation tests

  • Unit tests: Included with code coverage information
  • Integration tests: Details about the test cases and coverage

Security checks

Samples

N/A (No sample impact)

Related PRs

Migrations (if applicable)

N/A (No migration steps required)

Test environment

Tested on JDK versions, operating systems, databases, and browser/versions as follows:

  • JDK: 11
  • OS: Mac
  • Database: H2
  • Browser: Chrome

Learning

The research phase involved an analysis of the introduced changes in asgardeo/asgardeo-auth-js-core#203.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Params passed to the Authorize request are getting moderated by the SDK.
2 participants