Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance getAuthorizationURL function #251

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Enhance getAuthorizationURL function #251

merged 6 commits into from
Apr 18, 2024

Conversation

movinsilva
Copy link
Contributor

Purpose

  • The purpose of this PR is to enhance the getAuthorizationURL function by introducing support to build authorization post functions.

Approach

  • The logic for building parameters of the getAuthorizationURL function is abstracted out and exposed as a new function called getAuthorizationURLParams.

Related Issue

@movinsilva
feat: 🎨 extract and expose parameters building logic out of getAuthor…
1521d4a 
…izationURL function

can use the getAuthorizationURLParams() to build the authorize api call (usable for api based authentication)
@movinsilva
docs: 📝 update the example for the getAuthorizationURLParams
643ec7b
pavinduLakshan
pavinduLakshan reviewed Apr 17, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/src/client.ts Outdated Show resolved Hide resolved
lib/src/client.ts Outdated Show resolved Hide resolved
lib/src/client.ts Show resolved Hide resolved
lib/src/client.ts Show resolved Hide resolved
lib/src/core/authentication-core.ts Outdated Show resolved Hide resolved
@pavinduLakshan pavinduLakshan merged commit c8f710a into asgardeo:master Apr 18, 2024
1 check passed
@movinsilva movinsilva mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavinduLakshan pavinduLakshan pavinduLakshan approved these changes

@brionmario brionmario Awaiting requested review from brionmario brionmario is a code owner

@NipuniBhagya NipuniBhagya Awaiting requested review from NipuniBhagya NipuniBhagya is a code owner

@inthirakumaaran inthirakumaaran Awaiting requested review from inthirakumaaran inthirakumaaran is a code owner

@jeradrutnam jeradrutnam Awaiting requested review from jeradrutnam jeradrutnam is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@movinsilva @pavinduLakshan