Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Params passed to the Authorize request are getting moderated by the SDK. #208

Closed
brionmario opened this issue Dec 20, 2023 · 1 comment · Fixed by asgardeo/asgardeo-auth-js-core#249, asgardeo/asgardeo-auth-spa-sdk#161 or #209
Labels
bug Something isn't working Priority/High

Comments

@brionmario
Copy link
Member

brionmario commented Dec 20, 2023

Describe the issue:

The following set of params are passed into the signIn hook.

const authParams = {};

authParams["fidp"] = "OrganizationSSO";
authParams["orgId"] = getOrganizationName();

await signIn(authParams);

And the SDK transforms the keys in to Snake Case which causes issues.

Screenshot 2023-12-20 at 17 10 36

This change seems to have been introduced with https://github.com/asgardeo/asgardeo-auth-js-core/pull/203/files#diff-f34c1fc70c8dfe6982556af3ab69b70a42b7a68c9119cfa0bfa4716acd929750R120.

How to reproduce:

  • Pass the above set of custom params to the signIn hook.

Expected behavior:

  • SDK should not transform the keys.

Environment information (Please complete the following information; remove any unnecessary fields) :

  • Product Version: IS 7.0 BETA 4
  • OS: Mac
  • Database: H2
  • Userstore: LDAP
@brionmario
Copy link
Member Author

Fixed in @asgardeo/auth-js and propagated to @asgardeo/auth-spa & @asgardeo/auth-react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment