-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect out-of-sync lock file in the pr builder #238
base: main
Are you sure you want to change the base?
Conversation
d6b450c
to
13ecff0
Compare
@@ -38,6 +38,15 @@ jobs: | |||
uses: actions/setup-node@v1 | |||
with: | |||
node-version: ${{ matrix.node-version }} | |||
|
|||
- name: Install dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the proper fix here would be to remove the prebuild
script that installs packages and do the install explicitly.
As a temp workaround, we can do a yarn install --frozen-lockfile
before the yarn build
- name: Build
run: |
+ yarn install --frozen-lockfile
yarn build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the proper fix here would be to remove the prebuild script that installs packages and do the install explicitly.
Removing the prebuild script would cause inconsistent lock files being used to package the release artifact, wouldn't it?
Purpose
$subject
Related issues