Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

DebugLogger nuget package doesn't contain Debug.WriteLine #216

Closed
alexvaluyskiy opened this issue Jul 8, 2015 · 5 comments
Closed

DebugLogger nuget package doesn't contain Debug.WriteLine #216

alexvaluyskiy opened this issue Jul 8, 2015 · 5 comments
Assignees
Milestone

Comments

@alexvaluyskiy
Copy link

Microsoft.Framework.Logging.Debug nuget package on Myget doesn't contain Debug.WriteLine() in the code.

@alexvaluyskiy alexvaluyskiy changed the title DebugLogger nuget package don't contain Debug.WriteLine DebugLogger nuget package doesn't contain Debug.WriteLine Jul 8, 2015
@davidfowl
Copy link
Member

That's right. it's in this package https://www.nuget.org/packages?q=System.Diagnostics.Debug. The System* packages are where the BCL types exist.

@alexvaluyskiy
Copy link
Author

I'm talking about this line

if (string.IsNullOrEmpty(message))
{
    return;
}

message = $"{ logLevel }: {message}";
* System.Diagnostics.Debug.WriteLine(message, _name); *

Debug.WriteLine marked with ConditionalAttribute and won't go to compiled code, when you compile and publish this code to nuget packages.

@kichalla kichalla reopened this Jul 8, 2015
@kichalla
Copy link
Member

kichalla commented Jul 8, 2015

@kichalla kichalla closed this as completed Jul 8, 2015
@kichalla kichalla reopened this Jul 8, 2015
@Eilon
Copy link
Member

Eilon commented Jul 8, 2015

Yes, this never worked at all due to the comment @kichalla pointed out.

@Eilon Eilon added the bug label Jul 8, 2015
@Eilon Eilon added this to the 1.0.0-beta6 milestone Jul 8, 2015
@Eilon
Copy link
Member

Eilon commented Jul 8, 2015

@victorhurdugaci can you take a look at this for beta 6?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants