Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Remove dependence Microsoft.Extensions.PlatformAbstractions #293

Closed
yuaom opened this issue Nov 14, 2015 · 2 comments
Closed

Remove dependence Microsoft.Extensions.PlatformAbstractions #293

yuaom opened this issue Nov 14, 2015 · 2 comments

Comments

@yuaom
Copy link

yuaom commented Nov 14, 2015

https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging.Console/ConsoleLogger.cs#L45
RuntimeEnvironmentHelper.IsWindows cann't run on .net core console host app, it can instead RuntimeInformation.IsOSPlatform(OSPlatform.Windows)

@davidfowl
Copy link
Member

@loqix in RC1 that's the case, but in RC2 it won't be. https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Extensions.PlatformAbstractions/DefaultRuntimeEnvironment.cs#L63

We'll likely remove the dependency anyways since it makes sense.

@muratg muratg added this to the 1.0.0-rc2 milestone Dec 18, 2015
@muratg
Copy link

muratg commented Dec 18, 2015

Fixed in 6738803

@muratg muratg closed this as completed Dec 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants