Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Microsoft.Extensions.Logging depends on Microsoft.Extensions.Configuration #630

Closed
MaxDeg opened this issue Jun 1, 2017 · 2 comments
Closed
Assignees

Comments

@MaxDeg
Copy link

MaxDeg commented Jun 1, 2017

Microsoft.Extensions.Logging depends on nuget Microsoft.Extensions.Configuration instead of Microsoft.Extensions.Configuration.Abstractions.

As Logging only use interface defined in Configuration.Abstractions it should reference this nuget.
Isn't it much better for coupling to depend on Abstractions nuget only?

@DamianEdwards
Copy link
Member

We intend to fix this in the following way:

  • Remove dependency on Microsoft.Extensions.Configuration from Microsoft.Extension.Logging
  • Add a new package Microsoft.Extensions.Logging.Configuration and move the configuration-dependent logging APIs & integration to it (it would depend on Microsoft.Extensions.Logging.Configuration or Microsoft.Extensions.Logging.Configuration.Abstractions as appropriate
  • Update Microsoft.AspNetCore to depend on Microsoft.Extensions.Logging.Configuration and call the logging->configuration integration API to bring it all together.

@muratg
Copy link

muratg commented Jun 8, 2017

@pakrym Good to close?

@pakrym pakrym closed this as completed Jun 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants