Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Build libuv with VS2017 #29

Open
BrennanConroy opened this issue May 11, 2017 · 6 comments
Open

Build libuv with VS2017 #29

BrennanConroy opened this issue May 11, 2017 · 6 comments
Milestone

Comments

@BrennanConroy
Copy link
Member

BinSkim complains about some stack protectors when using VS2015 Update 2, its been fixed in VS2015 Update 3 or even better just use VS2017.

@moozzyk
Copy link
Contributor

moozzyk commented May 15, 2017

Building with VS2015 Update 2 is probably just a matter of updating VS on the agent(s). Building with VS2017 may require updating team city to be able to use latest MSBuild or changing MSBuild steps to cmd steps.

@muratg
Copy link
Contributor

muratg commented Sep 28, 2017

@natemcmaster do you think this will be a requirement with the new product build plans?

@natemcmaster
Copy link

Yes.

@muratg muratg added this to the 2.1.0 milestone Sep 28, 2017
@natemcmaster
Copy link

Also, consider using cmake. The CoreCLR team uses this to build native code so it will be available in our product-build toolsets.

@muratg
Copy link
Contributor

muratg commented Sep 28, 2017

OK, assigning to @ryanbrandenburg, he can take a look when he's back. 🎁

cc @Eilon

@moozzyk
Copy link
Contributor

moozzyk commented Sep 29, 2017

I like the idea of using libuv's build system but I am not sure how feasible it is. I don't think they support building for windows arm (not sure about Linux). They also do not use CMake but gyp/autotools.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants