-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Detect runtime-evaluated base classes defined in the current file (#8572
- Loading branch information
1 parent
4760af3
commit 722687a
Showing
10 changed files
with
103 additions
and
0 deletions.
There are no files selected for viewing
Empty file.
11 changes: 11 additions & 0 deletions
11
crates/ruff_linter/resources/test/fixtures/flake8_type_checking/module/direct.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
from __future__ import annotations | ||
|
||
from collections.abc import Sequence | ||
|
||
|
||
class MyBaseClass: | ||
pass | ||
|
||
|
||
class Foo(MyBaseClass): | ||
foo: Sequence |
9 changes: 9 additions & 0 deletions
9
crates/ruff_linter/resources/test/fixtures/flake8_type_checking/module/import.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
from __future__ import annotations | ||
|
||
from collections.abc import Sequence | ||
|
||
from module.direct import MyBaseClass | ||
|
||
|
||
class Foo(MyBaseClass): | ||
foo: Sequence |
7 changes: 7 additions & 0 deletions
7
crates/ruff_linter/resources/test/fixtures/flake8_type_checking/module/undefined.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
from __future__ import annotations | ||
|
||
from collections.abc import Sequence | ||
|
||
|
||
class Foo(MyBaseClass): | ||
foo: Sequence |
11 changes: 11 additions & 0 deletions
11
...f_linter/resources/test/fixtures/flake8_type_checking/runtime_evaluated_base_classes_5.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
from __future__ import annotations | ||
|
||
from collections.abc import Sequence # TCH003 | ||
|
||
|
||
class MyBaseClass: | ||
pass | ||
|
||
|
||
class Foo(MyBaseClass): | ||
foo: Sequence |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
...__flake8_type_checking__tests__typing-only-standard-library-import_module__direct.py.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
source: crates/ruff_linter/src/rules/flake8_type_checking/mod.rs | ||
--- | ||
|
4 changes: 4 additions & 0 deletions
4
...__flake8_type_checking__tests__typing-only-standard-library-import_module__import.py.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
--- | ||
source: crates/ruff_linter/src/rules/flake8_type_checking/mod.rs | ||
--- | ||
|
25 changes: 25 additions & 0 deletions
25
...lake8_type_checking__tests__typing-only-standard-library-import_module__undefined.py.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
source: crates/ruff_linter/src/rules/flake8_type_checking/mod.rs | ||
--- | ||
undefined.py:3:29: TCH003 [*] Move standard library import `collections.abc.Sequence` into a type-checking block | ||
| | ||
1 | from __future__ import annotations | ||
2 | | ||
3 | from collections.abc import Sequence | ||
| ^^^^^^^^ TCH003 | ||
| | ||
= help: Move into type-checking block | ||
|
||
ℹ Unsafe fix | ||
1 1 | from __future__ import annotations | ||
2 2 | | ||
3 |-from collections.abc import Sequence | ||
3 |+from typing import TYPE_CHECKING | ||
4 |+ | ||
5 |+if TYPE_CHECKING: | ||
6 |+ from collections.abc import Sequence | ||
4 7 | | ||
5 8 | | ||
6 9 | class Foo(MyBaseClass): | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters