Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid recommending Self usages in metaclasses #8639

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Avoid recommending Self usages in metaclasses #8639

merged 1 commit into from
Nov 13, 2023

Conversation

charliermarsh
Copy link
Member

PEP 673 forbids the use of typing(_extensions).Self in metaclasses, so we want to avoid flagging PYI034 on metaclasses. This is based on an analogous change in flake8-pyi: PyCQA/flake8-pyi#436.

Closes #8353.

@charliermarsh charliermarsh added the bug Something isn't working label Nov 12, 2023
@github-actions GitHub Actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh merged commit 213d315 into main Nov 13, 2023
17 checks passed
@charliermarsh charliermarsh deleted the charlie/is-metaclass branch November 13, 2023 00:47
@miccal miccal mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add exception for PYI034 for the usage of Self in metaclasses
1 participant
@charliermarsh