Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(node:21463) [DEP0128] DeprecationWarning 2 times when running script/build #395

Open
DAC324 opened this issue Jun 23, 2022 · 2 comments
Open
Labels
bug Something isn't working medium-priority

Comments

@DAC324
Copy link

DAC324 commented Jun 23, 2022

Hello all,

when executing script/build, you will get two warnings from node:

(node:21463) [DEP0128] DeprecationWarning: Invalid 'main' field in '/opt/.cache/yay/atom/src/atom/out/app/node_modules/find-parent-dir/package.json' of 'find-parent-dir.js'. Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:21463) [DEP0128] DeprecationWarning: Invalid 'main' field in '/opt/.cache/yay/atom/src/atom/out/app/node_modules/isbinaryfile/package.json' of './lib/panino.js'. Please either fix that or report it to the module author

Here is a patch that will fix that.

--- a/node_modules/find-parent-dir/package.json	2022-06-21 15:00:18.055055351 +0200
+++ b/node_modules/find-parent-dir/package.json	2022-06-21 15:00:34.211336704 +0200
@@ -53,7 +53,7 @@
     "walk"
   ],
   "license": "MIT",
-  "main": "find-parent-dir.js",
+  "main": "index.js",
   "name": "find-parent-dir",
   "repository": {
     "type": "git",
--- a/node_modules/isbinaryfile/package.json	2022-06-21 15:01:18.460281392 +0200
+++ b/node_modules/isbinaryfile/package.json	2022-06-21 15:01:34.829890986 +0200
@@ -38,7 +38,7 @@
     "node": ">=0.6.0"
   },
   "homepage": "https://github.com/gjtorikian/isBinaryFile#readme",
-  "main": "./lib/panino.js",
+  "main": "index.js",
   "maintainers": [
     {
       "name": "Garen J. Torikian",
@ghost
Copy link

ghost commented Jul 13, 2022

Maybe the people who work on this project can solve it by getting the patch somewhere in this repo.

@aminya
Copy link
Member

aminya commented Jul 13, 2022

These are the external dependencies (find-parent-dir and isbinaryfile). They might get fixed by updating their versions. If not, we might need to hot patch the code.

@aminya aminya added bug Something isn't working medium-priority labels Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium-priority
Projects
None yet
Development

No branches or pull requests

2 participants