Allow list of files in Dependencies methods #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
hagenw
added a commit
that referenced
this pull request
Feb 23, 2024
* Allow list of files in Dependencies methods * Add first tests * Extend tests * Update docstrings
hagenw
added a commit
that referenced
this pull request
May 3, 2024
* Allow list of files in Dependencies methods * Add first tests * Extend tests * Update docstrings
hagenw
added a commit
that referenced
this pull request
May 3, 2024
hagenw
added a commit
that referenced
this pull request
May 3, 2024
* Allow list of files in Dependencies methods * Add first tests * Extend tests * Update docstrings
hagenw
added a commit
that referenced
this pull request
May 3, 2024
hagenw
added a commit
that referenced
this pull request
May 3, 2024
* Allow list of files in Dependencies methods * Add first tests * Extend tests * Update docstrings
hagenw
added a commit
that referenced
this pull request
May 3, 2024
hagenw
added a commit
that referenced
this pull request
May 8, 2024
* Allow list of files in Dependencies methods * Add first tests * Extend tests * Update docstrings
hagenw
added a commit
that referenced
this pull request
May 8, 2024
This was referenced May 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support for passing on a list of files to all file based methods of
audb.Dependencieslikeaudb.Depednencies.archive(files).I decided against returning always a list as results to not break backwards compatibility.
Now you always get a list back when you use a list of files as a request.
If you request with an empty list, you will also get an empty list as results.
If you request a non-existing file, it will fail with the same error in both cases.
This provides the possibility to access a huge amount of files much faster than by
[deps.archive(file) for file in files].At the moment the benchmarks show that the speed enhancement can only be observed for the case of storing strings as
objectdtype. But I checked already that the same speed for the two other benchmark columns can be achieved when using alwaysobjectasdtypefor the index.Example change to docstring:
The actual code inside
audbis not yet changed to take advantage of the newfilesargument as I first will tackle the speed issue we see when using it with storing strings asstringdtype.