Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on pandas>=2.0.1 #406

Merged
merged 8 commits into from
May 13, 2024
Merged

Depend on pandas>=2.0.1 #406

merged 8 commits into from
May 13, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented May 10, 2024

The changes introduced in #372 require a certain pandas version to work.
The tests in this repo fail for pandas==1.5.3 and pandas==2.0.0, so I changed the minimum required pandas version to 2.0.1.

In addition, it adds tests for the latest pandas minor versions (2.0.3, 2.1.4), that are not part of the current development minor version (2.1.x).

@hagenw hagenw marked this pull request as draft May 10, 2024 13:07
@hagenw hagenw changed the title CI: run tests for different pandas versions Depend on pandas>=2.1.0 May 10, 2024
@hagenw hagenw marked this pull request as ready for review May 10, 2024 13:16
@hagenw hagenw changed the title Depend on pandas>=2.1.0 Depend on pandas>=2.0.3 May 10, 2024
@hagenw hagenw changed the title Depend on pandas>=2.0.3 Depend on pandas>=2.0.1 May 10, 2024
@hagenw hagenw requested a review from ChristianGeng May 10, 2024 13:39
Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MR alters the build matrix for our CI pipelines, with adding two different Python pandas versions for Python 3.10. Even after testing lists, we couldn't manage with a dryer version of the build matrix.

Therefore this can be counted as approved.

@hagenw hagenw merged commit e85e75e into main May 13, 2024
9 checks passed
@hagenw hagenw deleted the test-pandas-versions branch May 13, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants