-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on pandas>=2.0.1 #406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hagenw
changed the title
CI: run tests for different pandas versions
Depend on pandas>=2.1.0
May 10, 2024
hagenw
commented
May 13, 2024
This reverts commit 958b886.
ChristianGeng
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MR alters the build matrix for our CI pipelines, with adding two different Python pandas versions for Python 3.10. Even after testing lists, we couldn't manage with a dryer version of the build matrix.
Therefore this can be counted as approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in #372 require a certain
pandas
version to work.The tests in this repo fail for
pandas==1.5.3
andpandas==2.0.0
, so I changed the minimum requiredpandas
version to2.0.1
.In addition, it adds tests for the latest
pandas
minor versions (2.0.3, 2.1.4), that are not part of the current development minor version (2.1.x).