Ensure dependency loading from cache does not fail #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianGeng
approved these changes
May 16, 2024
|
This is really annoying. Turns out under Windows it is failing again with another error: https://github.com/audeering/audinterface/actions/runs/9094046905/job/25052936311?pr=172 :( |
|
I guess we have to add a test for it, or we should catch all exceptions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen in https://github.com/audeering/audinterface/actions/runs/9094046905/job/25009555875?pr=172 and is decribed at audeering/audinterface#172 (comment), loading of an existing dependency table from cache, stored by an older version of
audbthan 1.7, might fail withKeyErrorunder Python 3.8.I added
KeyErrorto the list of the errors we catch when trying to load the cache file,and show in audeering/audinterface#174 that this fixes the problem we see for the test in
audinterface.I have opted against catching all possible errors, as we do not want to catch an Interruption initiated by the user, e.g. keyboard interruption.