Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokenGetter does not support Promise #747

Closed
jakubnavratil opened this issue Oct 20, 2022 · 2 comments · Fixed by #748
Closed

tokenGetter does not support Promise #747

jakubnavratil opened this issue Oct 20, 2022 · 2 comments · Fixed by #748
Labels

Comments

@jakubnavratil
Copy link

Description

While JWT_OPTIONS supports passing tokenGetter as function returning Promise, service does not work with that.

@frederikprijck
Copy link
Member

Thanks for reporting, it does look like the JwtHelperService does not account for the tokenGetter to return a promise.

I will look into this and see how we can resolve this.

@frederikprijck
Copy link
Member

👋 I opened a draft PR, would you be able to have a look and see if that would work for you?

I will be adding some more tests before merging that PR tho, as the SDK lacks alot of tests and I want to ensure we limit chances of breaking people with changes like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants