Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to skip issuer URL verification #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vivida1
Copy link

@Vivida1 Vivida1 commented Sep 3, 2024

The validator checks if the issuer URL and aud inside the access token match their corresponding provided configuration. It is possible to pass multiple audiences to the validator, but it is not possible to provide multiple issuer URLs. Without breaking and changing a lot of code, it seems the easiest way to allow for multiple applications (-> issuer URLs) was to just skip the issuer URL validation.

Afaik this does still comply with the specifications.

📝 Checklist

  • [ x] All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

Where am I suppose to add the documentation?

🔧 Changes

A validator option called SkipIssuerURLVerification was added to skip the verification of issuer URLs in access tokens.

📚 References

#197
#276

🔬 Testing

See test in validator_test.go

This helps when using multiple issuer URLs or applications.
@Vivida1 Vivida1 requested a review from a team as a code owner September 3, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant