-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Error message includes details of unrelated resource #202
Comments
Thanks for the bug report @alexpulver. The metadata is just appended information for CDK. The error message still displays
VersioningConfiguration is not defined, but also appends CDK data. Would you prefer that be optional? |
Thanks for clarifying @dchakrav-github! I wasn't sure if Guard appended the AWS CDK metadata purposefully or accidentally. The message formatting is a bit too verbose - contains Guard internal structure instead of a string. Also, having that metadata not as part of the error message would be helpful. That's what mainly caused me to think it's a bug, as I included nothing in the error message to have this appear. I saw your comment on #204 - if you think that approach makes sense; I think it would be preferable to the current behavior.
|
Please check out the Guard 2.1.0 Release that should resolve this issue. |
Thanks @razcloud! It looks great now. P.S.: There seems to be a space missing after the "Message" string, but it's a minor thing 😃 .
|
@alexpulver Thank you for letting us know about that! Will have that corrected. |
Describe the bug
When adding a custom error message,
cfn-guard
also prints details of unrelated resource from the data.To Reproduce
Please supply:
LandingPageFrontend.guard
LandingPageFrontend.template.json
-v
log level if it's not related to cfn-guard-lambda, or the relevant CloudWatch log messages if it is related to the cfn-guard-lambdaNOTE: Please be sure that the templates, rules and logs you provide as part of your bug report do not contain any sensitive information.
Expected behavior
A clear and concise description of what you expected to happen.
If I remove the
Metadata
resource from the template, I get a clean failure message, without the additional details. That is the expected behavior ifMetadata
would be in the template.Operating System:
[eg, MacOS, Windows, Ubuntu, etc]
macOS
OS Version
[eg Catalina, 10, 18.04, etc]
Catalina 10.15.7
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: