Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Reduce use of lesser known packages in Idemopotency package #568

Closed
1 of 2 tasks
mungojam opened this issue Mar 11, 2024 · 5 comments · Fixed by #578
Closed
1 of 2 tasks

Feature request: Reduce use of lesser known packages in Idemopotency package #568

mungojam opened this issue Mar 11, 2024 · 5 comments · Fixed by #578
Labels
area/idempotency feature-request New or enhancements to existing features status/confirmed The scope is clear, ready for implementation

Comments

@mungojam
Copy link

Use case

We have to be careful with the dependencies that we bring in. The Idempotency package brings in a JmesPath package which then brings in other sub-packages. The sub-packages are particularly obscure, developed as a university project with very few users. https://www.nuget.org/packages/Springcomp.GPPG.Runtime

We would like the JmesPath package dependency to be replaced with native System.Text.Json functionality, or else a more widely used package (e.g. Newtonsoft.Json).

Otherwise I don't think we will be able to make use of the Idempotency package.

Solution/User Experience

It seems that the main use is here, and could be replaced with a System.Text.Json use:

https://github.com/aws-powertools/powertools-lambda-dotnet/blob/develop/libraries/src/AWS.Lambda.Powertools.Idempotency/Serialization/JsonFunction.cs

Alternative solutions

No response

Acknowledgment

@mungojam mungojam added feature-request New or enhancements to existing features triage Pending triage from maintainers labels Mar 11, 2024
Copy link

boring-cyborg bot commented Mar 11, 2024

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #dotnet channel on our Powertools for AWS Lambda Discord: Invite link

@hjgraca
Copy link
Contributor

hjgraca commented Mar 11, 2024

@mungojam Thanks for raising this feature request. We are discussing what you wrote between the team and will get back to you soon.
I agree with you, the less dependencies we have the better, if we can achieve the same functionality with System.Text.Json seems like a good approach to me.

@hjgraca hjgraca added status/confirmed The scope is clear, ready for implementation and removed triage Pending triage from maintainers labels Apr 3, 2024
@hjgraca
Copy link
Contributor

hjgraca commented Apr 18, 2024

Hi @mungojam just to give you an update: PR created #578

@hjgraca hjgraca linked a pull request Apr 18, 2024 that will close this issue
5 tasks
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label May 9, 2024
@hjgraca
Copy link
Contributor

hjgraca commented May 10, 2024

@mungojam Release 1.10.0 removes dependency on 3rd party JMESPath. Using Idempotency 1.2.1 will not have that external dependency.
Hope you find it useful and reach out if you have any other questions or suggestions.
Thanks

@mungojam
Copy link
Author

@hjgraca nice one, thanks for the change. We'll look to adopt it now as nothing blocking anymore

@hjgraca hjgraca removed the pending-release Fix or implementation already in dev waiting to be released label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/idempotency feature-request New or enhancements to existing features status/confirmed The scope is clear, ready for implementation
Projects
Status: 👀 In review
Development

Successfully merging a pull request may close this issue.

3 participants