From 3e289752df4822f4cf893acacb29d8046f1fb6d3 Mon Sep 17 00:00:00 2001
From: Senthil Kumaran <senthilx@amazon.com>
Date: Fri, 31 May 2024 17:48:44 -0700
Subject: [PATCH] Run Kops Test Separately to triage failures. (#2936)

---
 .github/workflows/kops-test.yaml         | 51 ++++++++++++++++++++++++
 .github/workflows/weekly-cron-tests.yaml | 12 ------
 charts/aws-vpc-cni/README.md             |  1 +
 3 files changed, 52 insertions(+), 12 deletions(-)
 create mode 100644 .github/workflows/kops-test.yaml

diff --git a/.github/workflows/kops-test.yaml b/.github/workflows/kops-test.yaml
new file mode 100644
index 0000000000..b0e5c99c72
--- /dev/null
+++ b/.github/workflows/kops-test.yaml
@@ -0,0 +1,51 @@
+name: Kops tests
+
+on:
+  workflow_dispatch: {}
+  schedule:
+    - cron: "0 15 * * *" # every day
+
+permissions:
+  id-token: write
+  contents: read
+
+jobs:
+  daily-kops:
+    if: github.repository == 'aws/amazon-vpc-cni-k8s'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout latest commit in the PR
+        uses: actions/checkout@v3
+      - name: Set up Docker QEMU
+        uses: docker/setup-qemu-action@v2
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v2
+      - name: Set up Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: "1.22"
+      - name: Set up tools
+        run: |
+          # Install ginkgo version from go.mod
+          go install -mod=mod github.com/onsi/ginkgo/v2/ginkgo
+          curl --silent --location "https://github.com/weaveworks/eksctl/releases/latest/download/eksctl_$(uname -s)_amd64.tar.gz" | tar xz -C /tmp
+          sudo mv /tmp/eksctl /usr/local/bin/
+      - name: Set up AWS credentials
+        uses: aws-actions/configure-aws-credentials@v1
+        with:
+          role-to-assume: ${{ secrets.OSS_TEST_ROLE_ARN }}
+          role-duration-seconds: 28800 # 8 hours
+          aws-region: ${{ secrets.AWS_DEFAULT_REGION }}
+      - name: Run kops tests
+        env:
+          DISABLE_PROMPT: true
+          ROLE_CREATE: false
+          ROLE_ARN: ${{ secrets.EKS_CLUSTER_ROLE_ARN }}
+          RUN_CNI_INTEGRATION_TESTS: false
+          RUN_KOPS_TEST: true
+          K8S_VERSION: 1.30.0-beta.0
+          KOPS_VERSION: v1.29.0
+          KOPS_RUN_TOO_NEW_VERSION: 1
+        run: |
+          ./scripts/run-integration-tests.sh
+        if: always()
\ No newline at end of file
diff --git a/.github/workflows/weekly-cron-tests.yaml b/.github/workflows/weekly-cron-tests.yaml
index 505526b46e..1e09f43ab8 100644
--- a/.github/workflows/weekly-cron-tests.yaml
+++ b/.github/workflows/weekly-cron-tests.yaml
@@ -46,18 +46,6 @@ jobs:
           RUN_PERFORMANCE_TESTS: true
         run: |
           ./scripts/run-integration-tests.sh
-      - name: Run kops tests
-        env:
-          DISABLE_PROMPT: true
-          ROLE_CREATE: false
-          ROLE_ARN: ${{ secrets.EKS_CLUSTER_ROLE_ARN }}
-          RUN_CNI_INTEGRATION_TESTS: false
-          RUN_KOPS_TEST: true
-          K8S_VERSION: 1.30.0-beta.0
-          KOPS_VERSION: v1.28.4
-          KOPS_RUN_TOO_NEW_VERSION: 1
-        run: |
-          ./scripts/run-integration-tests.sh
         if: always()
       - name: Run bottlerocket tests
         env:
diff --git a/charts/aws-vpc-cni/README.md b/charts/aws-vpc-cni/README.md
index 155b127f30..13e16cbb68 100644
--- a/charts/aws-vpc-cni/README.md
+++ b/charts/aws-vpc-cni/README.md
@@ -77,6 +77,7 @@ The following table lists the configurable parameters for this chart and their d
 | `nodeAgent.image.pullPolicy` | Container pull policy                              | `IfNotPresent`                      |
 | `nodeAgent.securityContext`  | Node Agent container Security context              | `capabilities: add: - "NET_ADMIN" privileged: true` |
 | `nodeAgent.enableCloudWatchLogs`  | Enable CW logging for Node Agent              | `false`                             |
+ `nodeAgent.networkPolicyAgentLogFileLocation`  | Log File location of Network Policy Agent | `/var/log/aws-routed-eni/network-policy-agent.log` |
 | `nodeAgent.enablePolicyEventLogs` | Enable policy decision logs for Node Agent    | `false`                             |
 | `nodeAgent.metricsBindAddr` | Node Agent port for metrics                         | `8162`                              |
 | `nodeAgent.healthProbeBindAddr` | Node Agent port for health probes               | `8163`                              |