Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-cdk): cdk deploy documentation doesn't mention concurrent deploys #14344

Open
shellscape opened this issue Apr 23, 2021 · 9 comments
Open
Labels
documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@shellscape
Copy link

shellscape commented Apr 23, 2021

I opened #14316 recently, which was unceremoniously closed without further discussion around the crux of the problem. As @rix0rrr mentioned, there's a workaround for that particular problem, and his response would suggest that this is a known limitation of the framework at the moment.

Looking into the documentation in this repo, I can only find one mention of the flag here: https://github.com/aws/aws-cdk/tree/master/packages/aws-cdk#externally-executable-cloudformation-change-sets, which is a completely separate context and doesn't mention concurrent deployments via cdk deploy. #13024 added --change-set-name to the CLI, but the documentation doesn't mention other use cases for this flag.

The developer guide makes no mention of this flag, nor concurrent/parallel deployments https://docs.aws.amazon.com/cdk/latest/guide/cli.html and I'll raise a separate issue with them, pointing here.

This is a pretty big gap in the docs, and I'm honestly surprised that it hasn't been raised before with the increased commonality of monorepos for services and backend management. I'd like to suggest adding documentation to the README outlining known issues with parallel deployments, and pointing to using the --change-set-name flag to resolve the problem mentioned in the original bug issue.


This is a 📕 documentation issue

@shellscape shellscape added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 23, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 28, 2021

Parallel deployments are not possible. CloudFormation doesn't support it: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/using-cfn-updating-stacks-changesets.html

It's fair to say this limitation should have been mentioned in the docs. I will forward the ticket.

@rix0rrr rix0rrr removed their assignment May 10, 2021
@peterwoodworth peterwoodworth assigned ghost May 10, 2021
@NGL321 NGL321 added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 23, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jul 23, 2022
@shellscape
Copy link
Author

@jerry-aws @peterwoodworth @NGL321 given that @rix0rrr stated that it should be mentioned in the docs and the ticket was assigned, should this not be reopened?

@peterwoodworth peterwoodworth removed the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jul 29, 2022
@peterwoodworth peterwoodworth assigned peterwoodworth and unassigned ghost Jul 29, 2022
@peterwoodworth peterwoodworth removed their assignment Oct 16, 2023
@pahud pahud added p2 and removed p1 labels Jun 11, 2024
@shellscape
Copy link
Author

@pahud this just came up on Twitter again as an issue. what's the good word?

@pahud
Copy link
Contributor

pahud commented Jul 24, 2024

@shellscape Thank you for bringing this up to our attention.

Can you share the Twitter link?

I'd like to suggest adding documentation to the README outlining known issues with parallel deployments, and pointing to using the --change-set-name flag to resolve the problem mentioned in the original bug issue.

Reading this issue thread, looks like the last consensus is to add relevant description in the document. We should take actions, are you interested to submit a doc update PR to address that? I believe the maintainer would be happy to provide suggested changes based on your PR words and move it forward. What do you think?

@shellscape
Copy link
Author

@pahud
Copy link
Contributor

pahud commented Jul 24, 2024

@shellscape

Thank you. I read the tweets. If you still think we should add/improve relevant document as you mentioned in this issue description. Please kindly submit a PR to address this issue, I will bring this up to the team and make sure we move it forward.

@shellscape
Copy link
Author

respectfully, I'm not the right person to write that documentation. I lack the knowledge of the internals, the reasoning, or the alternatives.

@pahud
Copy link
Contributor

pahud commented Jul 24, 2024

@shellscape no worries, it doesn't have to be perfect. We just need to know what you expect to see in the README and a draft PR would be a perfect thing to get it started and make sure this stays in the backlog of the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

5 participants