Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eks: addCdk8sChart does not allow overwrite flag #25881

Open
gkaskonas opened this issue Jun 7, 2023 · 1 comment
Open

eks: addCdk8sChart does not allow overwrite flag #25881

gkaskonas opened this issue Jun 7, 2023 · 1 comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@gkaskonas
Copy link
Contributor

Describe the bug

The function uses KubernetManifest under the hood so it should allow overwrite

Expected Behavior

  const chart = new Chart(k8sApp, "chart", {
    namespace: NAMESPACE,
  });

  cluster.addCdk8sChart("chart", chart, {
    overwrite: true,
  });

This should work

Current Behavior

Argument of type '{ overwrite: boolean; }' is not assignable to parameter of type 'KubernetesManifestOptions'.
  Object literal may only specify known properties, and 'overwrite' does not exist in type 'KubernetesManifestOptions'.ts(2345)

Reproduction Steps

export function create(app: DCApplication, k8sApp: App): void {
  const { stack, cluster } = createResources(app);

  const chart = new Chart(k8sApp, "chart", {
    namespace: NAMESPACE,
  });

  cluster.addCdk8sChart("chart", chart, {
    overwrite: true,
  });
}

const app = new DCApplication();
const k8sApp = new App();
create(app, k8sApp);

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

v2.80.0

Framework Version

No response

Node.js Version

16

OS

Mac OS

Language

Typescript

Language Version

4.9.5

Other information

No response

@gkaskonas gkaskonas added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 7, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Jun 7, 2023
@pahud
Copy link
Contributor

pahud commented Jun 7, 2023

addCdk8sChart() comes with KubernetesManifestOptions. We need to add this new option for that before we are allowed to use it. I am making it a p2 feature request and we welcome any pull requests.

@pahud pahud added p2 feature-request A feature should be added or improved. effort/medium Medium work item – several days of effort and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 7, 2023
@pahud pahud changed the title (aws-eks): (addCdk8sChart does not allow overwrite flag) eks: addCdk8sChart does not allow overwrite flag Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants