aws-cdk-lib.aws_rds.DatabaseClusterProps: Deprecation Warnings

[argarinpauljohn]

Describe the feature

use writer and readers instead
This API will be removed in the next major release.
[WARNING] aws-cdk-lib.aws_rds.DatabaseClusterProps#instances is deprecated.

use writer and readers instead
This API will be removed in the next major release.

So we fixed this by using writer and readers instead. But CDK will destroy the old database instances then recreate them. This isn't good for us as restoring the data in the new databases will require us more time and work. Would it be possible for the CDK team to handle the migration?

Use Case

It will be cumbersome backing up the data and restoring them especially in our production databases.

Proposed Solution

Handle the migration of data in the background?

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.82.0

Environment details (OS name and version, etc.)

macOS Ventura 13.3.1

[peterwoodworth]

We do offer a migration path, have you tried this out? https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds-readme.html#migrating-from-instanceprops

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[argarinpauljohn]

Hi @peterwoodworth! Thanks I think it works now. I did specify the is_from_legacy_instance_props property but I didn't know instance name had to be Instance1, etc.

Some questions though:

1. In the original instance_props, there was a delete_automated_backups property. How can we specify that in writer/readers? The rds.ClusterInstance.provisioned method doesn't seem to support that.
2. rds.DatabaseCluster.instance_identifiers used to return something when the original instance_props is used. Now it returns nothing. Our current config is 1 writer and no reader. Is this expected? We are using these identifiers to subscribe to database instance events like availability, deletion, failover, etc.

[peterwoodworth]

1. It looks to me like there is not currently a way to set deleteAutomatedBackups. With the modern reader/writer API, we would need to add this, or else you would have to use escape hatches
2. On a quick glance it looks like instanceIdentifiers should be returning something. The instanceIdentifiers returned from this function is set as the construct property, but it looks like this is only done for readers, not for writers, so it would be expected in your case. I'm not familiar enough with this service however to know if that is right

   aws-cdk/packages/aws-cdk-lib/aws-rds/lib/cluster.ts

   Line 666 in 006b542

   instanceIdentifiers,

[argarinpauljohn]

Thank you @peterwoodworth! I will file separate issues to request for these features!

[peterwoodworth]

Great @argarinpauljohn, I've triaged and responded to both of them, should be pretty easy for any contributors to implement 🙂. I think we can close this issue out now that we have two separate ones, ping me if you have any more concerns.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[argarinpauljohn]

Thanks @peterwoodworth! I will try to contribute! :)