Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(module name): (short issue description) #26521

Closed
itaymelamed opened this issue Jul 26, 2023 · 2 comments
Closed

(module name): (short issue description) #26521

itaymelamed opened this issue Jul 26, 2023 · 2 comments
Labels
bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI

Comments

@itaymelamed
Copy link

Describe the bug

When trying to create a rule in AWS network firewall using ip set reference, once running cdk deploy , the value in the template for "reference_sets" is empty and i'm getting an internal error

Expected Behavior

value for reference_sets should be created

Current Behavior

Value is empty

Reproduction Steps

Create a aws network firewall rule with

                    reference_sets=networkfirewall.CfnRuleGroup.ReferenceSetsProperty(
                        ip_set_references={
                            "ip_set_references_key": {
                                "reference_arn": "referenceArn"
                            }
                        }
                    )

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.88

Framework Version

No response

Node.js Version

18.16.0

OS

Mac

Language

Python

Language Version

No response

Other information

No response

@itaymelamed itaymelamed added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 26, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jul 26, 2023
@peterwoodworth peterwoodworth removed the needs-triage This issue or PR still needs to be triaged. label Jul 26, 2023
@peterwoodworth
Copy link
Contributor

ipSetReferences wants an IPSetReferenceProperty type for the value. The following works for me:

        networkfirewall.CfnRuleGroup(self, "ruleGroup", 
            capacity=123,
            rule_group_name="ruleGroupName",
            type="type",
            description="description",
            rule_group=networkfirewall.CfnRuleGroup.RuleGroupProperty(
              rules_source=networkfirewall.CfnRuleGroup.RulesSourceProperty(
                rules_string="rulesString",
              ),
              reference_sets=networkfirewall.CfnRuleGroup.ReferenceSetsProperty(
                ip_set_references= {
                    "key" : networkfirewall.CfnRuleGroup.IPSetReferenceProperty(
                        reference_arn='arn'
                    )
                }
              )
            )
        )

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

2 participants