Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ecr: enable enhanced image scanning #26536

Open
2 tasks done
ginglis13 opened this issue Jul 27, 2023 · 1 comment
Open
2 tasks done

ecr: enable enhanced image scanning #26536

ginglis13 opened this issue Jul 27, 2023 · 1 comment
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p3

Comments

@ginglis13
Copy link

ginglis13 commented Jul 27, 2023

Describe the feature

Add CDK methods to enable enhanced image scanning for ECR repositories

https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-scanning-enhanced.html

Use Case

I would like to enable enhanced image scanning through CDK. The alternative route right now is to create a CFN stack using custom resources that invoke the AWS SDK.

Proposed Solution

Enabling enhanced image scanning is account wide, so updating the ImageScanningConfiguration Interface, which applies to a single repository, doesn't make much sense.

Instead, an ideal solution would be a top level method of aws_ecr, maybe something like:

import * as ecr from 'aws-cdk-lib/aws-ecr';

...


  ecr.EnableEnhancedImageScanning( {
     scanOnPush: true,
     filters: "*",
  });

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2

Environment details (OS name and version, etc.)

macOS 13.4

@ginglis13 ginglis13 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 27, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry label Jul 27, 2023
@peterwoodworth
Copy link
Contributor

The alternative route right now is to create a stack using custom resources that invoke the AWS SDK.

Until this is supported in CloudFormation this will remain true

@peterwoodworth peterwoodworth added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 27, 2023
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p3
Projects
None yet
Development

No branches or pull requests

3 participants