Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds: DatabaseInstance to support the creation of MSSQL DB bound to self managed AD instance. #28036

Open
2 tasks
zcvetkovicgscf opened this issue Nov 16, 2023 · 3 comments
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@zcvetkovicgscf
Copy link

zcvetkovicgscf commented Nov 16, 2023

Describe the feature

As recently announced AWS-RDS MsSQL Instances support the integration with self managed AD Instances, look at: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_SQLServer_SelfManagedActiveDirectory.html#USER_SQLServer_SelfManagedActiveDirectory.Managing

It Seams that cdk_rds is not supporting this feature.

Use Case

Create a RDS-MSSQL Instance coupled to a self managed Active Directory.

Proposed Solution

extend the DatabaseInstanceProps by needed parameters e.g.

domain-fqdn
domain-dns-ip
domain-ou
domain-auth-secret-arn

and implement it in DatabaseInstance constructor alt least for MSSQL engine.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.99.1

Environment details (OS name and version, etc.)

linux, macosx and GitHub

@zcvetkovicgscf zcvetkovicgscf added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2023
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Nov 16, 2023
@pahud
Copy link
Contributor

pahud commented Nov 16, 2023

I am not 100% sure if cloudformation has this support but yes, we could support that if it does.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2023
@zcvetkovicgscf
Copy link
Author

Thanks @pahud for the quick triage:
have a look - the given parameters are already defined for CloudFormation Resources
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds.CfnDBInstance.html:

domain: 'domain',
domainAuthSecretArn: 'domainAuthSecretArn',
domainDnsIps: ['domainDnsIps'],
domainFqdn: 'domainFqdn',
domainIamRoleName: 'domainIamRoleName',
domainOu: 'domainOu',

so I guess this it what you meant when looking if cloudformation has this support?

@pahud pahud changed the title aws-cdk-lib.aws_rds module DatabaseInstance: Support the creation of MSSQL DB bound to self managed AD instance. rds: DatabaseInstance to support the creation of MSSQL DB bound to self managed AD instance. Jun 4, 2024
@pahud
Copy link
Contributor

pahud commented Jun 4, 2024

Yes, sounds like it could be a new L2 for that. Please help us prioritize with 👍 .

@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

2 participants