StepFunctions: Label regex incorrect - denies s literal

[piurafunk]

Describe the bug

When adding a label to a DistributedMap, the regex denies a string that contains an s. The regex is here

> new RegExp('[\s\?\*\<\>\{\}\\[\\]\:\;\,\\\|\^\~\$\#\%\&\`\"]|[\u0000-\u001f]|[\u007f-\u009f]', 'gi').test('RestoreTablesInBatch')
true

It also doesn't deny white space, which the \s is supposed to do at the front:

> new RegExp('[\s\?\*\<\>\{\}\\[\\]\:\;\,\\\|\^\~\$\#\%\&\`\"]|[\u0000-\u001f]|[\u007f-\u009f]', 'gi').test('Reto re Ta  b leInBatch')
false

My DistributedMap definition:

new stepFunctions.DistributedMap(this, 'RestoreTablesInBatch', {
    label: 'RestoreTablesInBatch',
    maxConcurrency: 40,
    itemReader: new stepFunctions.S3ObjectsItemReader({
        bucket: bucket,
        prefix: stepFunctions.JsonPath.stringAt('$.batch'),
    }),
    itemSelector: {
        's3Data': stepFunctions.JsonPath.stringAt('$$.Map.Item.Value'),
        'destination_cluster': stepFunctions.JsonPath.stringAt('$.destination_cluster'),
        'asymmetricPrivateKeyArn': stepFunctions.JsonPath.stringAt('$.asymmetricPrivateKeyArn'),
    },
})

Expected Behavior

The inverse of these 2 examples. With an s should be fine, with whitespace should be denied.

Current Behavior

s is denied, whitespace is allowed.

Reproduction Steps

> new RegExp('[\s\?\*\<\>\{\}\\[\\]\:\;\,\\\|\^\~\$\#\%\&\`\"]|[\u0000-\u001f]|[\u007f-\u009f]', 'gi').test('RestoreTablesInBatch')
true

> new RegExp('[\s\?\*\<\>\{\}\\[\\]\:\;\,\\\|\^\~\$\#\%\&\`\"]|[\u0000-\u001f]|[\u007f-\u009f]', 'gi').test('Reto re Ta  b leInBatch')
false

Possible Solution

My guess is that it's related to the quoting in a JS file. When node interprets it, the \ characters are being interpreted by Node and stripped out, rather than by the RegEx[ object. When I build the RegExp object, Node CLI prints without \ characters:

> new RegExp('[\s\?\*\<\>\{\}\\[\\]\:\;\,\\\|\^\~\$\#\%\&\`\"]|[\u0000-\u001f]|[\u007f-\u009f]', 'gi')
/[s?*<>{}\[\]:;,\|^~$#%&`"]|[-]|[-

It seems it's not being gathered correctly. The \s becomes just s, and even the last closing bracket is missing, from the 2nd unicode grouping.

I tried submitting a PR, but it was closed due to redtape: #29763
I submitted a 2nd one, this one didn't get automatically closed: #29765

Additional Information/Context

No response

CDK CLI Version

2.135.0

Framework Version

No response

Node.js Version

v20.12.1

OS

Docker - Alpine

Language

TypeScript

Language Version

No response

Other information

No response

[khushail]

thanks for reporting this and submitting a PR @piurafunk . I see your PR has been reviewed and approved by CDK Team owner but its not updated with main branch code, thats why its not merged yet.

[piurafunk]

Thanks, I hadn't noticed that. I've updated it just now.

[piurafunk]

This is now resolved via the referenced PR.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[aws-cdk-automation]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.