Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless Code Version - required #66

Closed
mindstorms6 opened this issue Jun 8, 2018 · 5 comments · Fixed by #67
Closed

Serverless Code Version - required #66

mindstorms6 opened this issue Jun 8, 2018 · 5 comments · Fixed by #67

Comments

@mindstorms6
Copy link
Contributor

mindstorms6 commented Jun 8, 2018

Howdy!

According to the serverless docs : https://github.com/awslabs/serverless-application-model/blob/master/versions/2016-10-31.md#s3-location-object

The version of a code thing isn't required

Data Types
S3 Location Object
Specifies the location of an S3 object as a dictionary containing Bucket, Key, and optional Version properties.

Example:

CodeUri:
  Bucket: mybucket-name
  Key: code.zip
  Version: 121212

But we've got it marked non optional in our code
( i think it's sourced from : https://github.com/awslabs/aws-cdk/blob/4a7eaa6846d54c383022266809e3c3d3100992b6/packages/aws-cdk-resources/cloudformation-specs/000_sam.spec.json#L197 )

And putting a dummy value (like 0 is super not valid)

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 8, 2018

Yep, that sounds about right.

First reflex: don't use SAM :P

Second reflex: easy fix. Do you need it badly? Also, isn't it about bed time for you?

@eladb
Copy link
Contributor

eladb commented Jun 11, 2018

Can we pull in the latest version of the SAM spec from here

@eladb eladb reopened this Jun 11, 2018
@eladb
Copy link
Contributor

eladb commented Jun 11, 2018

I think this is the latest one https://github.com/awslabs/goformation/blob/master/generate/sam-2016-10-31.json and I think it's aligned to the one we have checked-in.

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 11, 2018

awslabs/goformation#87

But we get the model from a project called goformation, that's probably not the REAL source of truth, is it?

@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 17, 2018

We'll have to deal with this on a case-by-case basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants