Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check api compatibility version fixes #8055

Closed
MrArnoldPalmer opened this issue May 18, 2020 · 1 comment
Closed

check api compatibility version fixes #8055

MrArnoldPalmer opened this issue May 18, 2020 · 1 comment
Assignees
@MrArnoldPalmer
Labels
feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI

Comments

@MrArnoldPalmer
Copy link
Contributor

The check-api-compatibility script has a flag "DOWNLOAD_LATEST" that dictates whether to compare the local APIs to the latest versions published in NPM, or against packages with the version number in the local lerna.json file.

When DOWNLOAD_LATEST is false, check-api-compatibility breaks on branches that have been "bumped", AKA the version in lerna.json is not yet published. Instead the behavior should be...

If the value of DOWNLOAD_LATEST is not explicitly satisfied, check to see if the version inside lerna.json is published to NPM.

  • If the version exists, use that as a comparison target
  • If the version does not exist, us the version tagged as latest as the comparison target.
    -->

The Question

Environment

  • CDK CLI Version: 1.39.0
  • Module Version: 1.39.0
  • OS: all
  • Language: Typescript
@MrArnoldPalmer MrArnoldPalmer added the needs-triage This issue or PR still needs to be triaged. label May 18, 2020
@MrArnoldPalmer MrArnoldPalmer self-assigned this May 18, 2020
@SomayaB SomayaB added feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI and removed needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2020
@MrArnoldPalmer
Copy link
Contributor Author

Closed by #8427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrArnoldPalmer MrArnoldPalmer

Labels
feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrArnoldPalmer @SomayaB