Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose v1 is deprecated #448

Closed
chenrui333 opened this issue Jul 21, 2023 · 3 comments
Closed

docker-compose v1 is deprecated #448

chenrui333 opened this issue Jul 21, 2023 · 3 comments

Comments

@chenrui333
Copy link

see this comment

relates to #442

@petewalker
Copy link

In fact, it's actually EOL. Is it possible to remove the dependency from the package, or make it an extra?

This project seems to already require that Docker is installed for some of its commands in any case:

https://github.com/aws/aws-elastic-beanstalk-cli/blob/54abc1e09380c00b67c52b9f89b0c0177fddb519/ebcli/containers/commands.py#L60C1-L61

So, moving docker compose to be an external dependency seems reasonable to me?

@NihalM99 NihalM99 closed this as completed Aug 3, 2023
@petewalker
Copy link

Hi @NihalM99 - I'm not sure this resolves this issue fully? docker-compose is EOL - increasing the version range doesn't really help the problem. The last release for docker-compose was over 3 years ago.

As an example of its issues, it places an upper limit on PyYAML of <6, which can lead to this issue: yaml/pyyaml#724

@swiffer
Copy link

swiffer commented Sep 3, 2023

@petewalker - looks like #464 addresses the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants