Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring boot 3, apache 5 client, inconsistency with aws-xray-sdk #379

Open
oleksandr-skoryi opened this issue Apr 19, 2023 · 4 comments
Open

Comments

@oleksandr-skoryi
Copy link

Hi all, spring boot 3 uses apache 5 client.
I want to use
com.amazonaws.xray.proxies.apache.http.HttpClientBuilder and inject it in the HttpComponentsClientHttpRequestFactory and then in the rest template.
Unfortunately it is not possible, because HttpClientBuilder returns the client for the apache v4. Do you plan to move forward with apache5 or what kind of the workaround do you suggest?

@oleksandr-skoryi oleksandr-skoryi changed the title Spring boot 3, apache 5 client Spring boot 3, apache 5 client, inconsistency with aws-xray-sdk Apr 19, 2023
@atshaw43
Copy link
Contributor

atshaw43 commented May 1, 2023

Hello,

Thanks for brining this to our attention!

It looks like apache 4.x and 5.x are incompatible.

And unfortunately there is not an abstract interface we can change to that will work with both. According to the migration guide, we will need a rewrite on some key classes.

I'm afraid I do not see a short term easy fix for you. The solution will require making a parallel set of classe(s) for the new Apache version, specifically around TracedHttpClient. It looks like we just need to swap out the imports, but there may be some functional changes too. More investigation is needed.

I have added a work item in our backlog to look into this.

@raftheunis87
Copy link

Hey @atshaw43, is there any update on this issue?

@mxiamxia
Copy link

mxiamxia commented Dec 4, 2023

Hi @raftheunis87 @oleksandr-skoryi , AWS X-Ray is slowing down the new features/changes support on aws-xray-sdk and recommending our customers to use OpenTelemetry SDK for the auto/manual instrumentations in X-Ray. We're providing more richful features and support with OTel solutions. Any obstacle for you to onboard with OTel SDK in X-Ray? Please let us know. Thanks!

@LvvvlZ
Copy link

LvvvlZ commented Jul 18, 2024

Hey @atshaw43, is there any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants