Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For Ariadne #339

Open
rmorshea opened this issue May 27, 2022 · 3 comments
Open

Support For Ariadne #339

rmorshea opened this issue May 27, 2022 · 3 comments
Assignees
Labels

Comments

@rmorshea
Copy link

Ariadne is a popular GraphQL server for Python. It would be great if there were built-in support for Ariadne within this X-Ray SDK.

This snippet describing how to integrate Ariadne with OpenTelemetry could be used as a model for how to get something similar working with this X-Ray SDK.

@rmorshea
Copy link
Author

I'd be willing to implement this myself given some guidance.

@srprash
Copy link
Contributor

srprash commented Jun 6, 2022

Hi @rmorshea
Thanks for opening this feature request and offering to contribute. If possible, I think it would be worth it to open this request with opentelemetry python contrib. Opentelemetry python already has a broad array of library instrumentation and stable community support, as well as with ADOT, it is officially supported with X-Ray.

If you need this feature specifically in X-Ray SDK, we will be happy to work with you. :)

@rmorshea
Copy link
Author

rmorshea commented Jun 6, 2022

I'd be interested in a pursuing the X-Ray SDK solution for two reasons:

  1. I'm on a team within AWS - so no reason to go with a cloud-agnostic solution from what I can tell.
  2. Our team is relatively inexperienced with cloud infra so standing up ADOT seems like more than we can manage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants