Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampling configuration should discuss DefaultSampler vs. LocalSampler #404

Open
SamStephens opened this issue Sep 18, 2023 · 1 comment
Open

Sampling configuration should discuss DefaultSampler vs. LocalSampler #404

SamStephens opened this issue Sep 18, 2023 · 1 comment
Labels
aws-docs-update keep track of aws-docs with feature support update in SDK

Comments

@SamStephens
Copy link

The Sampling documentation describes how to configure sampling rules. However it does not make it clear that by default the DefaultSampler will be used, and for local sampling rules to be preferred to those from the X-Ray control plane, you need to configure the XRayRecorder to use the LocalSampler.
@srprash srprash mentioned this issue Sep 25, 2023
Merged
@srprash
Copy link
Contributor

srprash commented Sep 25, 2023

Thanks for bringing the gap to out notice. We will have the doc fixed and updated in our next release.

@srprash srprash added the aws-docs-update keep track of aws-docs with feature support update in SDK label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aws-docs-update keep track of aws-docs with feature support update in SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SamStephens @srprash