Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPC CNI chart specifies min/ip target settings as windows only #1120

Open
ryanwholey opened this issue Jun 11, 2024 · 0 comments
Open

VPC CNI chart specifies min/ip target settings as windows only #1120

ryanwholey opened this issue Jun 11, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ryanwholey
Copy link

Describe the bug

I'm seeking clarity on why the warm/min IP target values have been grouped under Windows settings. From the documentation, both on the AWS EKS side as well as the VPC CNI side, they read as if Windows mode is not related. I believe they apply to non-windows node types as well (see the linux prefix delegation mode). I propose we update the chart to declassify them as Windows settings because they may be overlooked by linux-only cluster operators.

Steps to reproduce

Chart values: https://github.com/aws/eks-charts/blob/master/stable/aws-vpc-cni/values.yaml#L102-L104
EKS docs: https://aws.github.io/aws-eks-best-practices/networking/vpc-cni/
CNI docs: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/docs/eni-and-ip-target.md

Expected outcome

Clarity as to why warm/min ip and warm prefix target values are categorized as windows settings. If these are found to not be windows-specific, I'm happy to submit a PR to add new inputs and deprecate or remove the old ones as yall see fit.

Environment

  • Chart name: aws-vpc-cni
  • Chart version: 1.18.2
  • Kubernetes version: 1.26
  • Using EKS (yes/no), if so version? yes, 1.26

Additional Context:

@ryanwholey ryanwholey added the bug Something isn't working label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant