Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Configure initContainers.pullPolicy, init.image.pullPolicy, and nodeAgent.image.pullPolicy not being respect #1147

Open
zyue110026 opened this issue Sep 7, 2024 · 0 comments · May be fixed by #1148
Labels
bug Something isn't working

Comments

@zyue110026
Copy link

Describe the bug
We have noticed three instances of incorrect helming in some of your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from aquasecurity/trivy-operator#729 regarding the incorrect helming defect.

initContainers.pullPolicy does not take effect when changed to a value other than default value 'IfNotPresent'. This is due to missing implementation for this value in appmesh-spire-agent/templates/deployment.yaml file:

initContainers:
- name: init
image: "{{ .Values.initContainers.image }}"
args:
- -t

init.image.pullPolicy, and nodeAgent.image.pullPolicy does not take effect when changed to a value other than default value 'Always'. This is due to missing implementation for this value in aws-vpc-cni/templates/daemonset.yaml file:

initContainers:
- name: aws-vpc-cni-init
image: {{ include "aws-vpc-cni.initImage" . }}

- name: aws-eks-nodeagent
image: {{ include "aws-vpc-cni.nodeAgentImage" . }}

Steps to reproduce
modify these values in values.yaml file, then deploy them.
Expected outcome
The changes for image pull policy should be respected.

Environment

  • Chart name: appmesh-spire-agent, and 12597f/stable/aws-vpc-cni
  • Chart version: main version
  • Kubernetes version:
  • Using EKS (yes/no), if so version?

Additional Context:

@zyue110026 zyue110026 added the bug Something isn't working label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant