Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Project] Database queries should use React Query #304

Open
5 of 8 tasks
kmcginnes opened this issue Apr 15, 2024 · 0 comments
Open
5 of 8 tasks

[Project] Database queries should use React Query #304

kmcginnes opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request exploration Issues related to graph exploration, node & edge details, neighbor expansion, etc performance Issues relating to performance search Issues related to search functionality

Comments

@kmcginnes
Copy link
Collaborator

kmcginnes commented Apr 15, 2024

Database queries go through a custom fetch process within React code. This requires a lot of boilerplate context, hooks, callbacks, memos, etc of React specific code. But this logic amounts to a simple async fetch call with a set of parameters.

Benefits

  • React Query has built in caching that does not depend on HTTP caching
  • React Query has configurable retries
  • Moving connector & explorer logic to functions will make them easier to understand, test, and might improve React rendering performance
  • Moving connector & explorer logic to functions will make it easier to move this logic to the server or create an independent package/library

Related Issues

Preferred Solution


Tip

Please use a 👍 reaction to provide a +1/vote.

This helps the community and maintainers prioritize this request.

Important

If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@kmcginnes kmcginnes added the enhancement New feature or request label Apr 15, 2024
@kmcginnes kmcginnes added performance Issues relating to performance search Issues related to search functionality exploration Issues related to graph exploration, node & edge details, neighbor expansion, etc labels Apr 24, 2024
@kmcginnes kmcginnes self-assigned this May 1, 2024
@kmcginnes kmcginnes modified the milestones: Release 1.6.1, Release 1.6.2 May 1, 2024
@kmcginnes kmcginnes added this to the Release 1.8.0 milestone May 8, 2024
@kmcginnes kmcginnes changed the title [Feature Request] Database queries should use React Query Database queries should use React Query May 8, 2024
@kmcginnes kmcginnes changed the title Database queries should use React Query [Project] Database queries should use React Query May 13, 2024
@kmcginnes kmcginnes removed this from the Release 1.8.0 milestone Jun 11, 2024
@kmcginnes kmcginnes removed this from the Release 1.10.0 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exploration Issues related to graph exploration, node & edge details, neighbor expansion, etc performance Issues relating to performance search Issues related to search functionality
Projects
No open projects
Status: 👀 In review
Development

No branches or pull requests

1 participant