Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for deploying Graph Explorer in Amazon ECS #174

Merged
merged 8 commits into from
Sep 7, 2023

Conversation

StrongPa55word
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c6b8842) 9.76% compared to head (8f2e4a7) 9.76%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #174   +/-   ##
=====================================
  Coverage   9.76%   9.76%           
=====================================
  Files        463     463           
  Lines      30853   30853           
  Branches     712     712           
=====================================
  Hits        3013    3013           
  Misses     27449   27449           
  Partials     391     391           
Flag Coverage Δ
unittests 9.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelnchin michaelnchin self-requested a review September 7, 2023 02:33
michaelnchin
michaelnchin previously approved these changes Sep 7, 2023
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the write-up @StrongPa55w0rd !

I restructured/revised the docs for better readability, and moved them into a separate directory. Looks good to merge, but please have another pass and see if I missed anything.

@StrongPa55word
Copy link
Contributor Author

Looks good..Thanks

@michaelnchin michaelnchin merged commit 1363ab4 into aws:main Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants