Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed search UI crashing on node select/preview #177

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

michaelnchin
Copy link
Member

Issue #, if available: #165

Description of changes:

  • Fixed a bug where the keyword search handler failed to pass sufficient PaginationOptions to the details preview renderer upon node selection.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #177 (0e0af6a) into main (fe4c614) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #177      +/-   ##
========================================
- Coverage   9.35%   9.35%   -0.01%     
========================================
  Files        463     463              
  Lines      30765   30768       +3     
  Branches     235     235              
========================================
  Hits        2877    2877              
- Misses     27882   27885       +3     
  Partials       6       6              
Files Changed Coverage Δ
...plorer/src/modules/KeywordSearch/KeywordSearch.tsx 0.00% <0.00%> (ø)

@michaelnchin michaelnchin merged commit f00eba6 into main Aug 23, 2023
1 of 3 checks passed
@michaelnchin michaelnchin deleted the Issue-165 branch August 23, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Bug] Graph Explorer UI crashes when previewing node details under search
1 participant