Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings in GitHub workflows #181

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Conversation

cubeddu
Copy link
Contributor

@cubeddu cubeddu commented Aug 29, 2023

Issue #156

Updated build_docker.yml and unit.yml to address annotations from deprecation warnings.

This PR addresses issue #156 by updating the build_docker.yml and unit.yml files to use the latest versions of the actions and address annotations from deprecation warnings.

In build_docker.yml, we updated the actions/checkout action to the latest version.

In unit.yml, we updated the actions/setup-node action to version 2 and removed the node-version option, which is now deprecated. We also updated the codecov/codecov-action action to version 3 and removed the directory and files options, which are not necessary for the default configuration.

Links to the updated files:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.33% 🎉

Comparison is base (29dbd6b) 9.43% compared to head (aba7c2f) 9.76%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #181      +/-   ##
========================================
+ Coverage   9.43%   9.76%   +0.33%     
========================================
  Files        463     463              
  Lines      30853   30853              
  Branches     246     712     +466     
========================================
+ Hits        2911    3013     +102     
+ Misses     27935   27449     -486     
- Partials       7     391     +384     
Flag Coverage Δ
unittests 9.76% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 411 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/build_docker.yml Outdated Show resolved Hide resolved
.github/workflows/build_docker.yml Outdated Show resolved Hide resolved
michaelnchin
michaelnchin previously approved these changes Sep 6, 2023
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @cubeddu !

@michaelnchin michaelnchin merged commit c6b8842 into aws:main Sep 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants