Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings in GitHub workflows #181

Merged
merged 7 commits into from
Sep 7, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .github/workflows/build_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ on:
workflow_dispatch:
inputs:
image_tag:
description: 'ECR image tag type'
description: "ECR image tag type"
required: false
type: choice
options:
- 'latest'
- 'release'
default: 'latest'
- "latest"
- "release"
default: "latest"
push:
branches:
- main
Expand All @@ -31,18 +31,19 @@ jobs:
with:
path: "./"
id: package-version
if: runner.os != 'Windows'

- name: Get image tag
id: get-image-tag
run: |
if ${{ github.event_name == 'workflow_dispatch' }} ; then
if ${{ inputs.image_tag == 'release'}}; then
echo "image_tag=${{ steps.package-version.outputs.version }}" >> $GITHUB_OUTPUT
echo "image_tag=${{ steps.package-version.outputs.version }}" >> $GITHUB_ENV
michaelnchin marked this conversation as resolved.
Show resolved Hide resolved
else
echo "image_tag=latest" >> $GITHUB_OUTPUT
echo "image_tag=latest" >> $GITHUB_ENV
fi
else
echo "image_tag=latest" >> $GITHUB_OUTPUT
echo "image_tag=latest" >> $GITHUB_ENV
fi

- name: Configure AWS Credentials
Expand All @@ -66,7 +67,7 @@ jobs:
REGISTRY: ${{ steps.login-ecr-public.outputs.registry }}
REGISTRY_ALIAS: neptune
REPOSITORY: graph-explorer
IMAGE_TAG: ${{ steps.get-image-tag.outputs.image_tag }}
IMAGE_TAG: ${{ env.image_tag }}
run: |
docker build -t $REGISTRY/$REGISTRY_ALIAS/$REPOSITORY:$IMAGE_TAG .
docker build --build-arg NEPTUNE_NOTEBOOK=true -t $REGISTRY/$REGISTRY_ALIAS/$REPOSITORY:sagemaker-$IMAGE_TAG .
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@ jobs:
run: pnpm test

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v2
uses: codecov/codecov-action@v3
with:
directory: "./packages/graph-explorer/coverage"
files: "*.info"

flags: unittests