removed previous schema preservation for nodes, edges #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
======================================
Coverage 9.99% 10.00%
======================================
Files 406 406
Lines 30146 30137 -9
Branches 654 654
======================================
Hits 3014 3014
+ Misses 26798 26789 -9
Partials 334 334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
xiazcy
reviewed
Oct 20, 2023
charlesivie
previously approved these changes
Nov 24, 2023
xiazcy
approved these changes
Nov 27, 2023
Cole-Greer
approved these changes
Nov 28, 2023
cubeddu
added a commit
to cubeddu/graph-explorer
that referenced
this pull request
Jan 8, 2024
* removed previous schema preservation for nodes, edges --------- Co-authored-by: Michael Chin <chnmch@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #147:
Description of changes:
The previous schema preservation logic was removed to avoid retaining old values causing incorrect rendering of nodes and edges totals from the cached previous load.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.