Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API request options for non IAM users, enforce JSON response format for SPARQL #230

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

cubeddu
Copy link
Contributor

@cubeddu cubeddu commented Jan 20, 2024

Issue #, if available: #229

Description of changes:

  • Added options for non IAM calls, to fix issues with openCypher and SPARQL connections using proxy server.
  • Enforce JSON Accept header for SPARQL.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d15fca2) 10.01% compared to head (a4ce4e6) 10.01%.

Files Patch % Lines
...explorer/src/connector/openCypher/useOpenCypher.ts 0.00% 2 Missing ⚠️
...s/graph-explorer/src/connector/sparql/useSPARQL.ts 0.00% 2 Missing ⚠️
...graph-explorer/src/connector/gremlin/useGremlin.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   10.01%   10.01%   -0.01%     
==========================================
  Files         407      407              
  Lines       30089    30091       +2     
  Branches      655      655              
==========================================
  Hits         3014     3014              
- Misses      26740    26742       +2     
  Partials      335      335              
Flag Coverage Δ
unittests 10.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelnchin michaelnchin changed the title Refactor API request options for non IAM users Refactor API request options for non IAM users, enforce JSON response format for SPARQL Jan 20, 2024
@michaelnchin michaelnchin self-requested a review January 20, 2024 01:51
Copy link
Member

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @cubeddu !

@michaelnchin michaelnchin merged commit 04c7840 into aws:main Jan 20, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants