Fix issues in fetchSchema for OpenCypher #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcginnes
force-pushed
the
fix-fetch-schema
branch
from
a9a6ba1
to
898612c
Compare
packages/graph-explorer/src/connector/openCypher/queries/fetchSchema.ts
Outdated
Show resolved
Hide resolved
packages/graph-explorer/src/connector/openCypher/queries/fetchSchema.ts
Outdated
Show resolved
Hide resolved
packages/graph-explorer/src/connector/openCypher/queries/fetchSchema.test.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 10.06% 11.02% +0.95%
==========================================
Files 409 408 -1
Lines 30156 30166 +10
Branches 660 706 +46
==========================================
+ Hits 3036 3325 +289
+ Misses 26785 26508 -277
+ Partials 335 333 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@alexey-temnikov I believe with my recent changes this is ready for another review pass. |
|
I believe I have covered all comments in this PR and it is ready for another look. |
kmcginnes
force-pushed
the
fix-fetch-schema
branch
from
1f7773b
to
50a2bd5
Compare
alexey-temnikov
previously approved these changes
Mar 2, 2024
Merged
Some OpenCypher labels have no edges, but we were assuming they all did. This caused a null reference exception. I changed the assumption to allow for empty edges and added a guard check to skip empty labels.
Co-authored-by: Alexey Temnikov <alexey.temnikov@improving.com>
kmcginnes
force-pushed
the
fix-fetch-schema
branch
from
60c7ed6
to
0a54c4b
Compare
|
I brought in the latest from |
alexey-temnikov
approved these changes
Mar 4, 2024
vkagamlyk
pushed a commit
that referenced
this pull request
Mar 12, 2024
Description of changes: Fixes failure when retrieving schema of older Neptune DB with OpenCypher (moved to PR Fix issues in fetchSchema for OpenCypher #245) Fixes SPARQL keyword search by exact match Adds ID attribute for Gremlin and OpenCypher connections Adds test cases to keywordSearchTemplate for new ID functionality Adds missing test cases for SPARQL keywordSearchTemplate cases Changes default search attribute to ID for Gremlin and OpenCypher Changes default search attribute to rdfs:label for SPARQL Changes default search precision to Exact Changes behavior when node type selection changes to reset attribute and precision to the values above Changes OpenCypher search queries to execute concurrently when searching multiple vertices (i.e. "All") Includes formatting of only files that were modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
string[]orstring.gitignoreto/packages/graph-explorerto give VS Code the info it needs to search in the right foldersOn older versions of Neptune, where the summary API is not supported, there were some issues when fetching the schema for an OpenCypher connection.
In the case where OpenCypher returns an empty list for the edge properties, the entire
fetchSchemastack would fail. Now it will simply move to the next edge.I also determined that OpenCypher was returning an empty list in my case because of an incorrect assumption around the edge labels. It was trying to extract the label name from an array of label names, but in reality it was not an array. So we ended up with just the first character of the label name. To fix this, I check the response to ensure it is an array. If it isn't, then assume it is a string.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.