Remove “__all” from query in SPARQL #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cole-Greer
reviewed
Mar 15, 2024
...es/graph-explorer/src/connector/sparql/templates/keywordSearch/keywordSearchTemplate.test.ts
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 12.04% 12.04%
=======================================
Files 409 409
Lines 30468 30469 +1
Branches 762 764 +2
=======================================
+ Hits 3669 3670 +1
Misses 26467 26467
Partials 332 332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The "__all" predicates filter was being applied to the SPARQL query when chosen. It wasn't causing any harm, but it shouldn't be there.
This PR removes it and updates the tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.